Fix code consistency and reliability issues

This commit addresses multiple code consistency and reliability issues across the codebase:

1. Version consistency - use package.json version (2.0.9) throughout
2. Improved module loading with better error handling and consistent symlinks
3. Enhanced data directory handling with better error checking
4. Fixed redundant code in main-installer.sh
5. Improved error handling in transmission-client.js
6. Added extensive module symlink creation
7. Better file path handling and permission checks
8. Enhanced API response handling

💡 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>

modules/file-creator-module.sh

@@ -41,9 +41,13 @@ function create_config_files() {
   # Create initial config.json
   echo "Creating config.json..."
   mkdir -p "$CONFIG_DIR"
+  
+  # Get version from package.json dynamically
+  VERSION=$(grep -oP '"version": "\K[^"]+' "${SCRIPT_DIR}/package.json" 2>/dev/null || echo "2.0.9")
+  
   cat > $CONFIG_DIR/config.json << EOF
 {
-  "version": "2.0.6",
+  "version": "$VERSION",
   "installPath": "$INSTALL_DIR",
   "transmissionConfig": {
     "host": "$TRANSMISSION_HOST",
@@ -301,12 +305,13 @@ app.use(bodyParser.urlencoded({ extended: true, limit: '50mb' }));
 //==============================
 
 // Get the version from package.json
-let appVersion = '2.0.6'; // Default fallback version
+let appVersion;
 try {
   const packageJson = require('./package.json');
   appVersion = packageJson.version;
 } catch (err) {
   console.warn('Could not read version from package.json, using default');
+  appVersion = '2.0.9'; // Default fallback version aligned with package.json
 }
 
 // Server status API

modules/rss-feed-manager.js

@@ -27,21 +27,19 @@ class RssFeedManager {
       
       // Log the data path for debugging
       console.log(`Data directory path set to: ${this.dataPath}`);
-      
-      // Create the data directory synchronously to make sure it exists
-      try {
-        // Check if fs.mkdirSync is available
-        if (fs.mkdirSync) {
-          const fsSync = require('fs');
-          if (!fsSync.existsSync(this.dataPath)) {
-            fsSync.mkdirSync(this.dataPath, { recursive: true });
-            console.log(`Created data directory synchronously: ${this.dataPath}`);
-          }
-        }
-      } catch (err) {
-        console.warn(`Warning: Could not create data directory synchronously: ${err.message}`);
-        // Will try again asynchronously in ensureDataDirectory
+    }
+    
+    // We'll always ensure the data directory exists regardless of where it's set
+    // Use synchronous operation to ensure directory exists immediately upon construction
+    try {
+      const fsSync = require('fs');
+      if (!fsSync.existsSync(this.dataPath)) {
+        fsSync.mkdirSync(this.dataPath, { recursive: true });
+        console.log(`Created data directory synchronously: ${this.dataPath}`);
       }
+    } catch (err) {
+      console.warn(`Warning: Could not create data directory synchronously: ${err.message}`);
+      // Will try again asynchronously in ensureDataDirectory when start() is called
     }
     
     // Maximum items to keep in memory to prevent memory leaks
@@ -158,10 +156,13 @@ class RssFeedManager {
     console.log(`Updating feed: ${feed.name || 'Unnamed'} (${feed.url})`);
     
     try {
+      // Get version from package.json if available, fallback to environment or hardcoded
+      const version = process.env.APP_VERSION || require('../package.json').version || '2.0.9';
+      
       const response = await fetch(feed.url, { 
         timeout: 30000,  // 30 second timeout 
         headers: {
-          'User-Agent': 'Transmission-RSS-Manager/2.0.6'
+          'User-Agent': `Transmission-RSS-Manager/${version}`
         }
       });
       
@@ -507,11 +508,16 @@ class RssFeedManager {
     }
   }
   
+  /**
+   * Ensures the data directory exists, using a consistent approach across the application
+   * @returns {Promise<boolean>} true if directory exists or was created
+   */
   async ensureDataDirectory() {
     try {
       // Create data directory with recursive option (creates all parent directories if they don't exist)
       await fs.mkdir(this.dataPath, { recursive: true });
       console.log(`Ensured data directory exists at: ${this.dataPath}`);
+      return true;
     } catch (error) {
       // Log the error details for debugging
       console.error(`Error creating data directory ${this.dataPath}:`, error);
@@ -521,9 +527,10 @@ class RssFeedManager {
         const { execSync } = require('child_process');
         execSync(`mkdir -p "${this.dataPath}"`);
         console.log(`Created data directory using fallback method: ${this.dataPath}`);
+        return true;
       } catch (fallbackError) {
-        console.error('Fallback method for creating data directory also failed:', fallbackError);
-        throw error; // Throw the original error
+        console.error('All methods for creating data directory failed:', fallbackError);
+        throw new Error(`Failed to create data directory: ${this.dataPath}. Original error: ${error.message}`);
       }
     }
   }

modules/transmission-client.js

@@ -125,6 +125,15 @@ class TransmissionClient {
    */
   async addTorrent(url, options = {}) {
     try {
+      // Verify client is initialized
+      if (!this.client) {
+        await this.initializeConnection();
+        
+        if (!this.client) {
+          throw new Error("Failed to initialize Transmission client");
+        }
+      }
+      
       const downloadDir = options.downloadDir || null;
       const result = await this.client.addUrl(url, {
         "download-dir": downloadDir,

modules/utils-module.sh

@@ -101,6 +101,29 @@ function create_dir_if_not_exists() {
 function ensure_npm_packages() {
   local install_dir=$1
   
+  # First ensure the installation directory exists
+  if [ ! -d "$install_dir" ]; then
+    log "INFO" "Creating installation directory: $install_dir"
+    mkdir -p "$install_dir" || {
+      log "ERROR" "Failed to create installation directory: $install_dir"
+      return 1
+    }
+  }
+  
+  # Ensure data directory exists
+  if [ ! -d "$install_dir/data" ]; then
+    log "INFO" "Creating data directory: $install_dir/data"
+    mkdir -p "$install_dir/data" || {
+      log "ERROR" "Failed to create data directory: $install_dir/data"
+      return 1
+    }
+    
+    # Initialize empty data files
+    echo "[]" > "$install_dir/data/rss-feeds.json"
+    echo "[]" > "$install_dir/data/rss-items.json"
+    log "INFO" "Initialized empty data files"
+  fi
+  
   # Ensure package.json exists in the installation directory
   if [ ! -f "$install_dir/package.json" ]; then
     log "INFO" "Copying package.json to installation directory..."
@@ -108,7 +131,7 @@ function ensure_npm_packages() {
       log "ERROR" "Failed to copy package.json to installation directory"
       return 1
     }
-  fi
+  }
   
   # Install NPM packages if not already installed or if it's an update
   if [ ! -d "$install_dir/node_modules" ] || [ "$IS_UPDATE" = "true" ]; then
@@ -199,9 +222,12 @@ function finalize_setup() {
     # Make sure CONFIG_DIR exists
     mkdir -p "$CONFIG_DIR"
     
+    # Get version from package.json dynamically
+    VERSION=$(grep -oP '"version": "\K[^"]+' "${SCRIPT_DIR}/package.json" 2>/dev/null || echo "2.0.9")
+    
     cat > $CONFIG_DIR/config.json << EOF
 {
-  "version": "2.0.6",
+  "version": "$VERSION",
   "transmissionConfig": {
     "host": "${TRANSMISSION_HOST}",
     "port": ${TRANSMISSION_PORT},