fix: slut-review — pcall om start/dialoger, Auto-varer fra aktivt AD-mål, nil-guards, README
This commit is contained in:
@@ -424,9 +424,13 @@ function SmartPickupFrame:onClickNew()
|
||||
end
|
||||
|
||||
function SmartPickupFrame:onClickRename()
|
||||
local run = self:getRun()
|
||||
if run == nil then return end
|
||||
TextInputDialog.show(SmartPickupFrame.onRenameResult, self, run.name, self.i18n:getText("spu_renameTitle"), nil, 30, g_i18n:getText("button_ok"))
|
||||
-- Dialogen kan kaste (fx manglende i18n-nøgle) — fang det som resten af GUI'et, i stedet
|
||||
-- for at lade fejlen undslippe klik-callbacken uden statuslinje-besked.
|
||||
self:safe(function(frame)
|
||||
local run = frame:getRun()
|
||||
if run == nil then return end
|
||||
TextInputDialog.show(SmartPickupFrame.onRenameResult, frame, run.name, frame.i18n:getText("spu_renameTitle"), nil, 30, g_i18n:getText("button_ok"))
|
||||
end)
|
||||
end
|
||||
|
||||
function SmartPickupFrame:onRenameResult(value, clickOk)
|
||||
@@ -440,9 +444,12 @@ function SmartPickupFrame:onRenameResult(value, clickOk)
|
||||
end
|
||||
|
||||
function SmartPickupFrame:onClickDelete()
|
||||
local run = self:getRun()
|
||||
if run == nil then return end
|
||||
YesNoDialog.show(SmartPickupFrame.onDeleteResult, self, string.format(self.i18n:getText("spu_deleteConfirm"), run.name), self.i18n:getText("spu_button_delete"))
|
||||
-- Samme begrundelse som onClickRename: dialog-opkaldet skal ikke kunne undslippe uden om safe().
|
||||
self:safe(function(frame)
|
||||
local run = frame:getRun()
|
||||
if run == nil then return end
|
||||
YesNoDialog.show(SmartPickupFrame.onDeleteResult, frame, string.format(frame.i18n:getText("spu_deleteConfirm"), run.name), frame.i18n:getText("spu_button_delete"))
|
||||
end)
|
||||
end
|
||||
|
||||
function SmartPickupFrame:onDeleteResult(yes)
|
||||
|
||||
Reference in New Issue
Block a user